#23740: fix(run): generate Mistral-compatible tool call IDs (9-char alphanumeric)

## Summary Fixes #23595 Mistral models now work correctly without HTTP 400 errors. ## Problem Mistral API enforces strict tool call ID requirements: - Exactly 9 characters - Only a-z, A-Z, 0-9 (alphanumeric) - No underscores, hyphens, or other special characters OpenClaw was generating IDs like `call_1740241912345` which: - Contains underscores (`_`) ❌ - Has 17+ characters (variable length) ❌ Result: HTTP 400 error when using Mistral models: ``` 400 Tool call id was but must be a-z, A-Z, 0-9, with a length of 9. ``` ## Solution Added `generateToolCallId()` helper that generates compliant IDs: ```typescript function generateToolCallId(): string { const chars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789"; let result = ""; for (let i = 0; i < 9; i++) { result += chars.charAt(Math.floor(Math.random() * chars.length)); } return result; // Example: "aB3xK9mP2" } ``` ## Changes - `src/agents/pi-embedded-runner/run.ts`: - Added `generateToolCallId()` helper - Changed client tool call generation from `call_${Date.now()}` to `generateToolCallId()` - `src/agents/pi-embedded-runner/tool-call-id-generator.test.ts`: - 5 test cases verifying Mistral compliance ## Test Coverage ```typescript ✓ generates exactly 9 characters ✓ generates only alphanumeric characters (100 iterations) ✓ does not contain underscores (Mistral requirement) ✓ does not contain hyphens (Mistral requirement) ✓ generates unique IDs (1000 samples, <0.1% collision rate) ``` ## Verification Before fix: ``` id: `call_${Date.now()}` // "call_1740241912345" → HTTP 400 ❌ ``` After fix: ``` id: generateToolCallId() // "aB3xK9mP2" → HTTP 200 ✅ ``` ## Impact - Mistral models now work correctly - Other providers unaffected (they accept alphanumeric IDs) - No breaking changes to existing functionality <!-- greptile_comment --> <h3>Greptile Summary</h3> This PR fixes Mistral API compatibility by generating 9-character alphanumeric tool call IDs instead of the previous format (`call_${Date.now()}`). The change addresses HTTP 400 errors from Mistral's strict ID validation. The implementation includes: - New `generateToolCallId()` helper function in `src/agents/pi-embedded-runner/run.ts` - Comprehensive test coverage verifying Mistral compliance (9 chars, alphanumeric only) - Additional fixes for system-prompt cache locality and version comparison with build suffixes **Note:** The codebase already has a comprehensive tool call ID sanitization system (`src/agents/tool-call-id.ts`) with `strict9` mode that handles Mistral's requirements. Consider whether the new random ID generator could leverage or integrate with this existing infrastructure to maintain consistency across the codebase. <h3>Confidence Score: 4/5</h3> - This PR is safe to merge with minor style improvements recommended - The core fix correctly addresses the Mistral API requirements (9-char alphanumeric IDs). The implementation is straightforward and well-tested. Score is 4 (not 5) because: (1) the function duplicates code between test and implementation files, (2) uses Math.random() instead of cryptographically secure randomness like the existing codebase patterns, and (3) doesn't leverage the existing tool-call-id.ts infrastructure. These are style/consistency concerns rather than functional issues. - No files require special attention - the changes are localized and well-tested _{Last reviewed commit: e809762} <!-- greptile_other_comments_section --> _{(4/5) You can add custom instructions or style guidelines for the agent [here](https://app.greptile.com/review/github)!} <!-- /greptile_comment -->