#11882: fix: accept openai-codex/gpt-5.3-codex model refs
agents
stale
Cluster:
Context Window and Model Updates
Fixes embedded Slack agents failing with "Unknown model: openai-codex/gpt-5.3-codex" by normalizing provider/model formatting before lookup and allowing gpt-5.3-codex version-suffixed variants (e.g. gpt-5.3-codex-YYYY-MM-DD).\n\nAdds unit tests for normalization + version variants.
<!-- greptile_comment -->
<h2>Greptile Overview</h2>
<h3>Greptile Summary</h3>
This PR updates `resolveModel` to normalize provider IDs and trim model IDs before looking them up in the discovered model registry, and extends the existing OpenAI Codex forward-compat fallback to accept `gpt-5.3-codex` version-suffixed variants (e.g. `gpt-5.3-codex-YYYY-MM-DD`). It also adds unit tests covering provider/model formatting normalization and the new version-variant fallback behavior.
These changes sit in the pi-embedded runner’s model resolution path (`src/agents/pi-embedded-runner/model.ts`), which bridges configured providers/models (`cfg.models.providers`) with the model catalog discovered from auth/storage.
<h3>Confidence Score: 4/5</h3>
- This PR is close to safe to merge, but there is a provider-id mismatch edge case in the fallback path that can produce inconsistent provider identifiers.
- Core normalization + new codex version-variant fallback look correct and are covered by tests; the main remaining concern is the fallback model using a normalized provider string even when it sourced config from a non-normalized provider key, which can break downstream provider-keyed behavior in that specific configuration.
- src/agents/pi-embedded-runner/model.ts
<!-- greptile_other_comments_section -->
<!-- /greptile_comment -->
Most Similar PRs
#13229: Fix openai-codex/gpt-5.3-codex API format resolution
by trevorgordon981 · 2026-02-10
88.3%
#6053: fix: use 400K context window instead of 200K if the model allows (g...
by icedac · 2026-02-01
83.1%
#12220: fix: forward-compat models now respect user-configured contextWindow
by Batuhan4 · 2026-02-09
81.5%
#13626: fix(model): propagate provider model properties in fallback resolution
by mcaxtr · 2026-02-10
81.0%
#7570: fix: allow models from providers with auth profiles configured
by DonSqualo · 2026-02-03
80.5%
#3322: fix: merge provider config api into registry model
by nulone · 2026-01-28
80.3%
#14508: fix(models): allow forward-compat models in allowlist check
by jonisjongithub · 2026-02-12
80.0%
#15205: fix(models): normalize google-antigravity api field from google-gem...
by wboudy · 2026-02-13
79.8%
#9822: fix: allow local/custom model providers for sub-agent inference
by stammtobias91 · 2026-02-05
79.7%
#9583: fix(models): allow models in agents.defaults.models even if not in ...
by hotzen100 · 2026-02-05
79.6%