#12415: Code Quality: Add Strict Oxlint Configuration
stale
Cluster:
Test Coverage Enhancements
Added strict oxlint configuration to enforce:
- No unused variables
- Strict null checks
- No explicit any types
- Prefer const over let
- No var keyword
- No duplicate imports
Ensures better code quality and type safety moving forward
<!-- greptile_comment -->
<h2>Greptile Overview</h2>
<h3>Greptile Summary</h3>
This PR introduces a new `.oxlintrc` to enable stricter Oxlint rules (unused vars, const preference, duplicate imports, etc.) and extends `test/auto-reply.retry.test.ts` with cases intended to validate retry logging and max-attempt behavior for `deliverWebReply`.
The retry-related tests currently don’t align with the `deliverWebReply` API/behavior in `src/web/auto-reply/deliver-reply.ts`: they omit a required `textLimit` param, pass an unsupported `maxRetries` param, and assert on `replyLogger.warn` for retries even though retries are logged via `logVerbose` instead.
<h3>Confidence Score: 2/5</h3>
- This PR is not safe to merge as-is because the newly added retry tests don’t match the current `deliverWebReply` API/behavior and should fail CI.
- Confidence is reduced due to concrete test/API mismatches (missing required `textLimit`, unsupported `maxRetries`, and an assertion expecting retry warnings via `replyLogger.warn` that the implementation never emits). The Oxlint config itself is small, but the missing newline could also trip formatting checks.
- test/auto-reply.retry.test.ts, .oxlintrc
<!-- greptile_other_comments_section -->
<!-- /greptile_comment -->
Most Similar PRs
#12411: Test Improvements: Add Retry Logging and Max Attempts Handling
by dikshithreddym · 2026-02-09
78.5%
#11549: lint: add no-console rule and migrate 5 files to structured logger
by vaibhavtupe · 2026-02-08
74.8%
#11980: CLI: add external message lint + warn on tables/mentions
by moestradamos · 2026-02-08
72.7%
#23497: feat(retry): add retryHttpAsync utility with comprehensive coverage
by thinstripe · 2026-02-22
72.5%
#10367: CLI/Ops: resilient browser fill + failover hardening + operations t...
by cluster2600 · 2026-02-06
72.2%
#15948: fix(logging): prevent recursive logger/config stack overflow
by Glucksberg · 2026-02-14
70.0%
#12684: Test: add missing unit tests for src/utils modules
by shaynhornik · 2026-02-09
69.8%
#8800: chore: apply oxfmt formatting
by shamsulalam1114 · 2026-02-04
69.4%
#13881: fix: Address Greptile feedback - test isolation and channel resolution
by trevorgordon981 · 2026-02-11
69.4%
#7585: Tests: fix lint in discord auto-thread race test
by justinhuangcode · 2026-02-03
69.2%