← Back to PRs

#13666: test: make docker-setup Bash path portable on Windows

by rmdmattingly open 2026-02-10 20:37 View on GitHub →
docker stale
Fixes CI on Windows runners where /bin/bash doesn't exist (spawnSync returned status=null). Uses 'bash' on win32 and gracefully no-ops if bash isn't available. <!-- greptile_comment --> <h2>Greptile Overview</h2> <h3>Greptile Summary</h3> Changed the Bash 3.2 compatibility test to use `bash` instead of `/bin/bash` on Windows (where `/bin/bash` doesn't exist), and added graceful handling for environments where bash isn't available at all. - Made bash path platform-specific: uses `bash` on win32, `/bin/bash` elsewhere - Added null check to skip the compatibility test when bash isn't available (when `spawnSync` returns `status === null`) - Fixes CI failures on Windows runners where the hardcoded `/bin/bash` path caused the test to fail <h3>Confidence Score: 5/5</h3> - This PR is safe to merge with minimal risk - The changes are minimal, well-scoped, and defensive. The PR only modifies test code (not production code), uses proper platform detection, and adds graceful handling for missing bash. The logic is straightforward and doesn't introduce any new dependencies or breaking changes. - No files require special attention <!-- greptile_other_comments_section --> <sub>(2/5) Greptile learns from your feedback when you react with thumbs up/down!</sub> <!-- /greptile_comment -->

Most Similar PRs