#21977: Preserve provider API for discovered Ollama models

# Preserve provider API for discovered Ollama models Closes #20259 ## Summary This patch hardens model resolution so when registry-discovered models are missing `api`, OpenClaw hydrates the API from `models.providers.<provider>.api`. This prevents `mapOptionsForApi` from receiving `undefined` and crashing model calls for custom Ollama setups. ## Problem - Expected: Resolved models should always carry a valid API transport, inheriting provider-level `api` when model-level `api` is absent. - Actual: A discovered model can resolve with `api: undefined`, causing `Unhandled API in mapOptionsForApi: undefined`. - Impact: Runtime failures and dropped agent turns for affected Ollama configurations. ## Reproduction 1. Configure `models.providers.ollama.api = "openai-completions"` with custom model entries. 2. Resolve/run with a discovered Ollama model where registry entry lacks explicit `model.api`. - Expected result: Resolved model uses `openai-completions` API path. - Actual result: Resolved model may carry `api: undefined` and crash downstream transport mapping. ## Issues Found Severity: high Confidence: high Status: fixed | ID | Severity | Confidence | Area | Summary | Evidence | Status | | --- | --- | --- | --- | --- | --- | --- | | PR-21977-BUG-01 | high | high | `src/agents/pi-embedded-runner/model.ts` | Discovered model path returned `api: undefined` without provider-level fallback | `src/agents/pi-embedded-runner/model.ts:111` | fixed | ## Fix Approach - Resolve provider config once (including normalized provider key fallback). - For discovered models, if `model.api` is missing and provider config has `api`, hydrate `model.api` from provider config before returning. - Add unit coverage for discovered Ollama model with missing `api` to ensure provider fallback is applied. ## Testing - `pnpm test src/agents/pi-embedded-runner/model.test.ts` (pass) - `pnpm lint` (pass) - `pnpm tsgo` (pass) ## Risk / Notes - Low-risk scoped change in model resolution only; fallback applies only when discovered model `api` is missing. <!-- greptile_comment --> <h3>Greptile Summary</h3> Correctly fixes discovered Ollama models missing `api` by hydrating from provider config. The implementation moves provider config resolution earlier and adds fallback logic to hydrate `api` from `models.providers.<provider>.api` when a discovered model's `api` is undefined. This prevents runtime crashes in downstream transport mapping. Key changes: - Early provider config resolution with normalized provider ID lookup (more robust than before) - API hydration for discovered models when `api` is missing - Test coverage for the Ollama use case with `api: undefined` The fix is well-targeted and handles the edge case properly with optional chaining and conditional hydration. <h3>Confidence Score: 5/5</h3> - This PR is safe to merge with minimal risk - The change is narrowly scoped to model resolution, adds defensive hydration logic with proper null checks, includes test coverage for the primary use case, and actually improves provider config resolution with normalized ID lookup. The logic correctly uses conditional checks to only hydrate when `api` is missing, and the double normalization is safe/idempotent. - No files require special attention _{Last reviewed commit: 7bae3d5} <!-- greptile_other_comments_section --> <!-- /greptile_comment -->