← Back to PRs

#18942: fix(tui): trigger render after finalizing chat assistant message

by BinHPdev open 2026-02-17 06:11 View on GitHub →
channel: mattermost size: XS
## Summary - Add missing `tui.requestRender()` call after finalizing a regular chat assistant message, so the reply is immediately visible without requiring reconnection. ## Root Cause The regular chat message final state handler in `tui-event-handlers.ts` updated the chat log and refreshed session info but did not trigger a terminal render. The empty message path (line 162) and command message path (line 178) both call `tui.requestRender()`, but the regular chat message path (after line 203) was missing this call. This caused the finalized assistant message to remain invisible until the user reconnected (which triggers a full history reload). ## Changes - `src/tui/tui-event-handlers.ts`: Add `tui.requestRender()` after `void refreshSessionInfo?.()` in the regular chat final state handler. ## Test plan - [ ] Send a message in the TUI and verify the assistant reply appears immediately after completion - [ ] Verify the reply persists on reconnection Fix #18691 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- greptile_comment --> <h3>Greptile Summary</h3> adds missing `tui.requestRender()` call after finalizing regular chat assistant messages in the TUI event handler, making replies immediately visible - **Code fix**: correctly adds `tui.requestRender()` at src/tui/tui-event-handlers.ts:204, matching the pattern used in empty message (line 162) and command message (line 178) paths - **CHANGELOG issue**: the same fix entry was incorrectly added to 38 already-released versions (2026.2.15 and older), not just the current unreleased version (2026.2.16) <h3>Confidence Score: 2/5</h3> - code fix is correct but CHANGELOG has critical issue with 38 historical versions modified - the TUI render fix is technically sound and follows existing patterns, but the CHANGELOG was incorrectly modified to add the same entry to 38 already-released versions instead of only the unreleased version, which violates changelog best practices and could cause confusion - CHANGELOG.md requires attention to remove entries from historical versions <sub>Last reviewed commit: 8f36cdf</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment -->

Most Similar PRs