← Back to PRs

#16412: fix(config): align tools.web.fetch schema with firecrawl/readability settings

by ciberponk open 2026-02-14 18:41 View on GitHub →
size: XS
## Summary - fix(config): align tools.web.fetch schema with firecrawl/readability settings - Split from our `v2026.2.13` patch train as a single-purpose change for easier review. ## Why - Keep the diff focused and low-risk so it can be merged or reverted independently. ## Scope - Branch: `fix/tools-web-fetch-schema-firecrawl-readability-en` - Files changed: 2 - Key files: - `src/config/config.schema-regressions.test.ts` - `src/config/zod-schema.agent-runtime.ts` ## Test Plan - Suggested local command: - `./node_modules/.bin/vitest run src/config/config.schema-regressions.test.ts` - Validation status: - [ ] CI checks pass - [ ] Maintainer re-ran local tests ## Risk & Rollback - Risk: low to medium; impact limited to touched module(s). - Rollback: revert this PR commit(s) cleanly. ## Co-authorship - Co-authored by @ciberponk and Codex (GPT-5). <!-- greptile_comment --> <h3>Greptile Summary</h3> Adds the missing `readability` and `firecrawl` fields to the `ToolsWebFetchSchema` Zod schema in `zod-schema.agent-runtime.ts`, aligning it with the TypeScript types already defined in `types.tools.ts` and the runtime consumption in `web-fetch.ts`. A corresponding regression test is added to `config.schema-regressions.test.ts`. - The Zod schema fields match the TypeScript `ToolsConfig.web.fetch` type exactly — `readability` (boolean), and the `firecrawl` sub-object with `enabled`, `apiKey`, `baseUrl`, `onlyMainContent`, `maxAgeMs`, and `timeoutSeconds`. - `firecrawl.apiKey` is correctly registered as `sensitive` for config redaction. - The `.strict()` modifier on the firecrawl sub-object follows the existing pattern used throughout the schema file. - No issues found — this is a straightforward schema alignment with no logic or behavioral changes. <h3>Confidence Score: 5/5</h3> - This PR is safe to merge — it only adds missing Zod schema fields to match existing types and runtime code, with a corresponding regression test. - Score of 5 reflects that this is a minimal, focused change that brings the Zod validation schema into alignment with the already-defined TypeScript types and the runtime implementation. All new fields have correct types, constraints, and sensitivity annotations. The regression test validates the happy path. There are no logic changes, no new dependencies, and no behavioral changes. - No files require special attention. <sub>Last reviewed commit: 793e74d</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment -->

Most Similar PRs