← Back to PRs

#18858: fix(nextcloud-talk): replace console.log with runtime logging

by Clawborn open 2026-02-17 04:30 View on GitHub →
channel: nextcloud-talk channel: zalo channel: feishu size: XS trusted-contributor
Operational logs (pairing approval, verbose send) were using console.log, which bypasses the structured logger. Fix: Replace console.log with runtime.logging.getChildLogger().info() and respect verbose configuration. <!-- greptile_comment --> <h3>Greptile Summary</h3> replaces `console.log`/`console.error` with structured runtime logging across nextcloud-talk, feishu, and zalo extensions to respect verbose configuration and maintain consistent log formatting. - nextcloud-talk: replaced pairing approval and verbose send logs with `getNextcloudTalkRuntime().logging.getChildLogger().info()` - feishu: added verbose check before typing indicator error logs (but has runtime reference issue - see comments) - zalo: replaced error logs with `runtime.error?.()` and created `logVerbose` helper for consistent verbose logging **issue**: feishu implementation mixes `getFeishuRuntime()` for verbose checks with `runtime?.log` parameter for actual logging, which references different runtime instances <h3>Confidence Score: 2/5</h3> - contains logic error in feishu that will likely cause runtime issues - the feishu typing.ts has a critical bug where it checks verbose logging on one runtime instance but attempts to log to a different runtime parameter that may be undefined, causing the verbose check to be ineffective or logs to be lost - `extensions/feishu/src/typing.ts` needs fixing before merge <sub>Last reviewed commit: fc86ef7</sub> <!-- greptile_other_comments_section --> <!-- /greptile_comment -->

Most Similar PRs